mchades commented on code in PR #8958:
URL: https://github.com/apache/gravitino/pull/8958#discussion_r2472383378


##########
catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/converter/MysqlTypeConverter.java:
##########
@@ -97,6 +100,9 @@ public Type toGravitino(JdbcTypeBean typeBean) {
       case CHAR:
         return Types.FixedCharType.of(typeBean.getColumnSize());
       case TEXT:
+      case TINYTEXT:
+      case MEDIUMTEXT:
+      case LONGTEXT:
         return Types.StringType.get();

Review Comment:
   These four types will cast to the same type `String`, will this cause user 
confusion?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to