yuqi1129 commented on code in PR #8922:
URL: https://github.com/apache/gravitino/pull/8922#discussion_r2473611323
##########
core/src/main/java/org/apache/gravitino/storage/relational/utils/POConverters.java:
##########
@@ -440,21 +421,15 @@ public static TablePO initializeTablePOWithVersion(
*
* @param oldTablePO the old TablePO object
* @param newTable the new TableEntity object
- * @param needUpdateVersion whether need to update the version
* @param newSchemaId the new schema id
* @return TablePO object with updated version
*/
public static TablePO updateTablePOWithVersionAndSchemaId(
- TablePO oldTablePO, TableEntity newTable, boolean needUpdateVersion,
Long newSchemaId) {
+ TablePO oldTablePO, TableEntity newTable, Long newSchemaId) {
Long lastVersion;
Long currentVersion;
- if (needUpdateVersion) {
- lastVersion = oldTablePO.getLastVersion() + 1;
- currentVersion = lastVersion;
- } else {
- lastVersion = oldTablePO.getLastVersion();
- currentVersion = oldTablePO.getCurrentVersion();
- }
Review Comment:
The problem is that the data in `table_version_info` is tracked by the
version, if we do not do this change, it will break the definition of the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
