mchades commented on code in PR #8964:
URL: https://github.com/apache/gravitino/pull/8964#discussion_r2480312006
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceTableOperations.java:
##########
@@ -81,11 +91,15 @@ public Response createTable(
@PathParam("id") String tableId,
@QueryParam("mode") @DefaultValue("create") String mode, // create,
exist_ok, overwrite
@QueryParam("delimiter") @DefaultValue(NAMESPACE_DELIMITER_DEFAULT)
String delimiter,
- @HeaderParam("x-lance-table-location") String tableLocation,
- @HeaderParam("x-lance-table-properties") String tableProperties,
- @HeaderParam("x-lance-root-catalog") String rootCatalog,
Review Comment:
>
https://github.com/lancedb/lance-namespace/blob/b035daec6b7cce0bec484c18326100d07c9e33bb/java/lance-namespace-apache-client/api/openapi.yaml#L1194-L1203
They only define the parameters `x-lance-table-properties` and
`x-lance-table-location`, but do not define the headers that should have the
prefix `x-lance`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
