This is an automated email from the ASF dual-hosted git repository.

fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new a6d19603c8 [#8981] Improvement(iceberg-catalog): 
CatalogWrapperForREST.close() calls super.close()  (#8982)
a6d19603c8 is described below

commit a6d19603c815bee496a5b2ecb96e08e1be3037cb
Author: Xiaojian Sun <[email protected]>
AuthorDate: Fri Oct 31 18:37:48 2025 +0800

    [#8981] Improvement(iceberg-catalog): CatalogWrapperForREST.close() calls 
super.close()  (#8982)
    
    ### What changes were proposed in this pull request?
    
    CatalogWrapperForREST.close() calls super.close() to release parent
    class resources.
    
    ### Why are the changes needed?
    
    
    Fix: #([8981](https://github.com/apache/gravitino/issues/8981))
    
    ### Does this PR introduce _any_ user-facing change?
    
    N/A
    
    ### How was this patch tested?
    
    N/A
---
 .../gravitino/iceberg/service/CatalogWrapperForREST.java   | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git 
a/iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java
 
b/iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java
index df9192ebd7..2cac2c7b33 100644
--- 
a/iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java
+++ 
b/iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java
@@ -136,9 +136,17 @@ public class CatalogWrapperForREST extends 
IcebergCatalogWrapper {
   }
 
   @Override
-  public void close() {
-    if (catalogCredentialManager != null) {
-      catalogCredentialManager.close();
+  public void close() throws Exception {
+    try {
+      if (catalogCredentialManager != null) {
+        catalogCredentialManager.close();
+      }
+    } finally {
+      // Call super.close() to release parent class resources including:
+      // 1. Close underlying catalog (JdbcCatalog, WrappedHiveCatalog, etc.)
+      // 2. Close metadata cache
+      // 3. Cleanup JDBC drivers and threads (MySQL 
AbandonedConnectionCleanupThread, etc.)
+      super.close();
     }
   }
 

Reply via email to