jerqi commented on code in PR #9010:
URL: https://github.com/apache/gravitino/pull/9010#discussion_r2493555641
##########
docs/iceberg-rest-service.md:
##########
@@ -425,6 +425,14 @@ Gravitino provides a pluggable metrics store interface to
store and delete Icebe
| `gravitino.iceberg-rest.metricsStoreRetainDays` | The days to retain Iceberg
metrics in store, the value not greater than 0 means retain forever.
| -1 | No | 0.4.0 |
| `gravitino.iceberg-rest.metricsQueueCapacity` | The size of queue to store
metrics temporally before storing to the persistent storage. Metrics will be
dropped when queue is full. | 1000 | No | 0.4.0 |
+If you want to use jdbc as metrics store, you can set the
`gravitino.iceberg-rest.metricsStore` to `jdbc`, and set the following
configurations to connect to the database. You should initialize the database
using the sql scripts in the directory `scripts`.
+
+| Configuration item | Description
|
Default value | Required | Since Version |
+|--------------------------------------------|-------------------------------------------------------------------------------------------------------------|-------------------|----------|---------------|
+| `gravitino.iceberg-rest.jdbc-user` | The username of the JDBC
connection.
| (none) | No | 0.2.0 |
Review Comment:
Do we need so complex configurations? This implementation just provides a
basic implementation to let users set up quickly. Once we choose the JDBC. The
database will be one server. If having other requirements, users can implement
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
