yuqi1129 commented on code in PR #9016:
URL: https://github.com/apache/gravitino/pull/9016#discussion_r2493918438
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceTableOperations.java:
##########
@@ -176,11 +195,34 @@ public Response deregisterTable(
@Context HttpHeaders headers,
DeregisterTableRequest deregisterTableRequest) {
try {
+ validateDeregisterTableRequest(deregisterTableRequest);
DeregisterTableResponse response =
lanceNamespace.asTableOps().deregisterTable(tableId, delimiter);
return Response.ok(response).build();
} catch (Exception e) {
return LanceExceptionMapper.toRESTResponse(tableId, e);
}
}
+
+ private void validateCreateEmptyTableRequest(CreateEmptyTableRequest
request) {
+ Preconditions.checkArgument(
+ StringUtils.isNotBlank(request.getLocation()), "Table location must be
provided.");
Review Comment:
Did you handle it and remind users that they can set the location in the
schema and catalog? Currently, Gravitino does support the feature you address,
but I'm worried that it's not the design that Lance REST supports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
