mchades commented on code in PR #8777:
URL: https://github.com/apache/gravitino/pull/8777#discussion_r2508659093
##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/BaseGVFSOperations.java:
##########
@@ -661,6 +668,26 @@ protected Fileset getFileset(NameIdentifier filesetIdent) {
NameIdentifier.of(filesetIdent.namespace().level(2),
filesetIdent.name())));
}
+ /**
+ * Get the schema by the schema identifier from the cache or load it from
the server if the cache
+ * is disabled.
+ *
+ * @param schemaIdent the schema identifier.
+ * @return the schema.
+ */
+ protected Schema getSchema(NameIdentifier schemaIdent) {
+ return filesetMetadataCache
+ .map(cache -> cache.getSchema(schemaIdent))
Review Comment:
If you want to add the schemaCache to the GVFS, you should also:
1. update the description of
`fs.gravitino.filesetMetadataCache.cache.enable` in the user doc
2. add schema cache to the Python GVFS to align the behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
