mchades commented on code in PR #9073:
URL: https://github.com/apache/gravitino/pull/9073#discussion_r2521330979
##########
core/src/main/java/org/apache/gravitino/connector/GenericLakehouseTable.java:
##########
@@ -47,11 +47,16 @@ protected GenericLakehouseTable internalBuild() {
GenericLakehouseTable genericLakehouseTable = new
GenericLakehouseTable();
genericLakehouseTable.columns = this.columns;
genericLakehouseTable.comment = this.comment;
- genericLakehouseTable.properties =
- ImmutableMap.<String, String>builder()
- .putAll(this.properties)
- .put(Table.PROPERTY_TABLE_FORMAT, this.format)
- .buildKeepingLast();
+
+ if (format != null) {
+ genericLakehouseTable.properties =
+ ImmutableMap.<String, String>builder()
+ .putAll(this.properties)
+ .put(Table.PROPERTY_TABLE_FORMAT, this.format)
+ .buildKeepingLast();
+ } else {
Review Comment:
if so, should we throw an exception in the `else` block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
