yuqi1129 commented on code in PR #9103:
URL: https://github.com/apache/gravitino/pull/9103#discussion_r2522024622
##########
catalogs/catalog-generic-lakehouse/src/main/java/org/apache/gravitino/catalog/lakehouse/GenericLakehouseCatalogOperations.java:
##########
@@ -307,7 +307,16 @@ public Table createTable(
ident, columns, comment, newProperties, partitions, distribution,
sortOrders, indexes);
} catch (EntityAlreadyExistsException e) {
throw new TableAlreadyExistsException(e, "Table %s already exists",
ident);
- } catch (IOException e) {
+ } catch (Exception e) {
Review Comment:
I got what you want expressed. If we failed to execute
`store.put(entityToStore);`, and then when we try to execute
```
store.delete()
```
It will still ok as `delete` will not throw an exception if the entity does
not exist in the entity store.
Moving it out of the try block will need two try blocks
```java
try {
store.put()
} catch (EntityAlreadyExistsException) {
} catch (exception e) {
//
}
try {
// handle lance operations
} catch (Excetioon e) {
store.remove()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
