mchades commented on code in PR #9130:
URL: https://github.com/apache/gravitino/pull/9130#discussion_r2533859701
##########
catalogs/catalog-generic-lakehouse/src/main/java/org/apache/gravitino/catalog/lakehouse/GenericLakehouseCatalogOperations.java:
##########
@@ -39,11 +48,43 @@
import org.apache.gravitino.rel.expressions.sorts.SortOrder;
import org.apache.gravitino.rel.expressions.transforms.Transform;
import org.apache.gravitino.rel.indexes.Index;
+import org.apache.hadoop.fs.Path;
-/** Operations for interacting with a generic lakehouse catalog in Apache
Gravitino. */
+/**
+ * Operations for interacting with a generic lakehouse catalog in Apache
Gravitino.
+ *
+ * <p>This catalog provides a unified interface for managing lakehouse table
formats. It is designed
+ * to be extensible and can support various table formats through a common
interface.
+ *
+ * <p><b>Current Implementation Status:</b>
+ *
+ * <ul>
+ * <li>✅ <b>Schema Operations:</b> Fully supported (create, list, load,
alter, drop)
+ * <li>⚠️ <b>Table Operations:</b> In development - will be added in
subsequent releases
+ * <li>⚠️ <b>Managed Storage:</b> Framework in place, format-specific
implementations required
+ * </ul>
Review Comment:
We can leave some TODO comments on the corresponding methods instead of
describing them in the class JavaDoc, because it may be overlooked to modify
the JavaDoc during the subsequent development process.
##########
catalogs/catalog-generic-lakehouse/src/main/java/org/apache/gravitino/catalog/lakehouse/GenericLakehouseCatalogOperations.java:
##########
@@ -39,11 +48,43 @@
import org.apache.gravitino.rel.expressions.sorts.SortOrder;
import org.apache.gravitino.rel.expressions.transforms.Transform;
import org.apache.gravitino.rel.indexes.Index;
+import org.apache.hadoop.fs.Path;
-/** Operations for interacting with a generic lakehouse catalog in Apache
Gravitino. */
+/**
+ * Operations for interacting with a generic lakehouse catalog in Apache
Gravitino.
+ *
+ * <p>This catalog provides a unified interface for managing lakehouse table
formats. It is designed
+ * to be extensible and can support various table formats through a common
interface.
+ *
+ * <p><b>Current Implementation Status:</b>
+ *
+ * <ul>
+ * <li>✅ <b>Schema Operations:</b> Fully supported (create, list, load,
alter, drop)
+ * <li>⚠️ <b>Table Operations:</b> In development - will be added in
subsequent releases
+ * <li>⚠️ <b>Managed Storage:</b> Framework in place, format-specific
implementations required
+ * </ul>
+ *
+ * <p><b>Configuration:</b>
+ *
+ * <ul>
+ * <li>{@code lakehouse-dir}: Root directory for the catalog (optional)
+ * <li>{@code gravitino.bypass.*}: Properties passed to underlying storage
implementation
+ * </ul>
+ *
+ * <p>For detailed documentation, see: <a
+ * href="https://gravitino.apache.org/docs/generic-lakehouse-catalog";>Generic
Lakehouse Catalog
Review Comment:
This document link has not been finalized. To avoid forgetting to modify it
later and causing the link to point to an incorrect destination, it is
recommended to remove this link first.
##########
catalogs/catalog-generic-lakehouse/src/main/java/org/apache/gravitino/catalog/lakehouse/GenericLakehouseCatalogPropertiesMetadata.java:
##########
@@ -19,18 +19,36 @@
package org.apache.gravitino.catalog.lakehouse;
-import com.google.common.collect.ImmutableMap;
+import static
org.apache.gravitino.connector.PropertyEntry.stringOptionalPropertyEntry;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Maps;
+import java.util.List;
import java.util.Map;
import org.apache.gravitino.connector.BaseCatalogPropertiesMetadata;
import org.apache.gravitino.connector.PropertyEntry;
public class GenericLakehouseCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetadata {
- private static final Map<String, PropertyEntry<?>>
GENERIC_LAKEHOUSE_CATALOG_PROPERTY_ENTRIES =
- ImmutableMap.<String, PropertyEntry<?>>builder().build();
+ public static final String LAKEHOUSE_DIR = "lakehouse-dir";
Review Comment:
we use `location` finally, see:
https://github.com/apache/gravitino/blob/fe2efa77fd65ee65fb82bc960a69755883d8e889/catalogs/catalog-generic-lakehouse/src/main/java/org/apache/gravitino/catalog/lakehouse/GenericLakehouseCatalogPropertiesMetadata.java#L34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
