This is an automated email from the ASF dual-hosted git repository.

jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 8f7bc49df1 [#9137] fix(stats): initialize comparator with 
DEFAULT_COMPARATOR in default constructor (#9175)
8f7bc49df1 is described below

commit 8f7bc49df1f1034f9a554a718b8d11605c2f7290
Author: Kwon Taeheon <[email protected]>
AuthorDate: Wed Nov 19 13:21:34 2025 +0900

    [#9137] fix(stats): initialize comparator with DEFAULT_COMPARATOR in 
default constructor (#9175)
    
    ### What changes were proposed in this pull request?
    
    - Initialize the comparator with DEFAULT_COMPARATOR in the default
    constructor.
    
    ### Why are the changes needed?
    
    - The default constructor used by ALL_PARTITIONS does not initialize the
    comparator, which results in it being null.
    
    Fix: #9137
    
    ### Does this PR introduce _any_ user-facing change?
    
    - No.
    
    ### How was this patch tested?
    
    - Verified using the unit test included in the issue
    (testAllPartitionsComparator()).
    - Confirmed all existing tests continue to pass.
---
 .../main/java/org/apache/gravitino/stats/PartitionRange.java |  4 +++-
 .../java/org/apache/gravitino/stats/TestPartitionRange.java  | 12 ++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/api/src/main/java/org/apache/gravitino/stats/PartitionRange.java 
b/api/src/main/java/org/apache/gravitino/stats/PartitionRange.java
index 07dd80462a..1fa48f1a24 100644
--- a/api/src/main/java/org/apache/gravitino/stats/PartitionRange.java
+++ b/api/src/main/java/org/apache/gravitino/stats/PartitionRange.java
@@ -36,7 +36,9 @@ public class PartitionRange {
 
   private SortOrder comparator;
 
-  private PartitionRange() {}
+  private PartitionRange() {
+    this.comparator = DEFAULT_COMPARATOR;
+  }
 
   /** A PartitionRange that includes all partitions. */
   public static final PartitionRange ALL_PARTITIONS = new PartitionRange();
diff --git 
a/api/src/test/java/org/apache/gravitino/stats/TestPartitionRange.java 
b/api/src/test/java/org/apache/gravitino/stats/TestPartitionRange.java
index bb9ed079dd..d4cbfe58e2 100644
--- a/api/src/test/java/org/apache/gravitino/stats/TestPartitionRange.java
+++ b/api/src/test/java/org/apache/gravitino/stats/TestPartitionRange.java
@@ -95,4 +95,16 @@ public class TestPartitionRange {
         IllegalArgumentException.class,
         () -> PartitionRange.upTo("upper", PartitionRange.BoundType.CLOSED, 
null));
   }
+
+  @Test
+  public void testAllPartitionsComparator() {
+    SortOrder defaultSortOrder =
+        SortOrders.of(NamedReference.MetadataField.PARTITION_NAME_FIELD, 
SortDirection.ASCENDING);
+
+    PartitionRange allPartitions = PartitionRange.ALL_PARTITIONS;
+
+    Assertions.assertFalse(allPartitions.lowerPartitionName().isPresent());
+    Assertions.assertFalse(allPartitions.upperPartitionName().isPresent());
+    Assertions.assertEquals(defaultSortOrder, allPartitions.comparator());
+  }
 }

Reply via email to