This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 3213cfb20d [#9171] improvement(authz): remove loadedOwners in 
JcasbinAuthorizer (#9172)
3213cfb20d is described below

commit 3213cfb20d8e09e3f1c1d0381c000ac0efad7201
Author: yangyang zhong <[email protected]>
AuthorDate: Wed Nov 19 16:39:49 2025 +0800

    [#9171] improvement(authz): remove loadedOwners in JcasbinAuthorizer (#9172)
    
    ### What changes were proposed in this pull request?
    
    remove loadedOwners in JcasbinAuthorizer
    
    ### Why are the changes needed?
    
    Fix: #9171
    
    ### Does this PR introduce _any_ user-facing change?
    
    None
    
    ### How was this patch tested?
    
    Existing test
---
 .../server/authorization/jcasbin/JcasbinAuthorizer.java        | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git 
a/server-common/src/main/java/org/apache/gravitino/server/authorization/jcasbin/JcasbinAuthorizer.java
 
b/server-common/src/main/java/org/apache/gravitino/server/authorization/jcasbin/JcasbinAuthorizer.java
index beb1ac2675..090ba1e0b7 100644
--- 
a/server-common/src/main/java/org/apache/gravitino/server/authorization/jcasbin/JcasbinAuthorizer.java
+++ 
b/server-common/src/main/java/org/apache/gravitino/server/authorization/jcasbin/JcasbinAuthorizer.java
@@ -84,12 +84,6 @@ public class JcasbinAuthorizer implements 
GravitinoAuthorizer {
    */
   private Set<Long> loadedRoles = ConcurrentHashMap.newKeySet();
 
-  /**
-   * loadedOwners is used to cache owners that have loaded permissions. When 
the permissions of a
-   * role are updated, they should be removed from it.
-   */
-  private Set<Long> loadedOwners = ConcurrentHashMap.newKeySet();
-
   private Map<Long, Long> ownerRel = new ConcurrentHashMap<>();
 
   private Executor executor = null;
@@ -365,7 +359,6 @@ public class JcasbinAuthorizer implements 
GravitinoAuthorizer {
     MetadataObject metadataObject = 
NameIdentifierUtil.toMetadataObject(nameIdentifier, type);
     Long metadataId = MetadataIdConverter.getID(metadataObject, metalake);
     ownerRel.remove(metadataId);
-    loadedOwners.remove(metadataId);
   }
 
   @Override
@@ -491,7 +484,7 @@ public class JcasbinAuthorizer implements 
GravitinoAuthorizer {
   }
 
   private void loadOwnerPolicy(String metalake, MetadataObject metadataObject, 
Long metadataId) {
-    if (loadedOwners.contains(metadataId)) {
+    if (ownerRel.containsKey(metadataId)) {
       LOG.debug("Metadata {} OWNER has bean loaded.", metadataId);
       return;
     }
@@ -509,7 +502,6 @@ public class JcasbinAuthorizer implements 
GravitinoAuthorizer {
         if (ownerEntity instanceof UserEntity) {
           UserEntity user = (UserEntity) ownerEntity;
           ownerRel.put(metadataId, user.id());
-          loadedOwners.add(metadataId);
         }
       }
     } catch (IOException e) {

Reply via email to