juiceyang commented on code in PR #9191:
URL: https://github.com/apache/gravitino/pull/9191#discussion_r2554822747
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/GravitinoCatalogManager.java:
##########
@@ -56,10 +56,10 @@ private GravitinoCatalogManager(
*/
public static GravitinoCatalogManager create(
String gravitinoUri, String metalakeName, Map<String, String>
gravitinoClientConfig) {
- Preconditions.checkState(
- gravitinoCatalogManager == null, "Should not create duplicate
GravitinoCatalogManager");
- gravitinoCatalogManager =
- new GravitinoCatalogManager(gravitinoUri, metalakeName,
gravitinoClientConfig);
+ if (gravitinoCatalogManager == null) {
+ gravitinoCatalogManager =
+ new GravitinoCatalogManager(gravitinoUri, metalakeName,
gravitinoClientConfig);
+ }
Review Comment:
No need to consider thread safety. The calling method is marked with the
synchronized keyword.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
