yuqi1129 commented on code in PR #9207:
URL: https://github.com/apache/gravitino/pull/9207#discussion_r2554965121
##########
core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/postgresql/FilesetMetaPostgreSQLProvider.java:
##########
@@ -29,35 +29,31 @@ public class FilesetMetaPostgreSQLProvider extends
FilesetMetaBaseSQLProvider {
public String softDeleteFilesetMetasByMetalakeId(Long metalakeId) {
return "UPDATE "
+ META_TABLE_NAME
- + " SET deleted_at = floor(extract(epoch from(current_timestamp -"
- + " timestamp '1970-01-01 00:00:00')) * 1000)"
+ + " SET deleted_at = CAST(EXTRACT(EPOCH FROM CURRENT_TIMESTAMP) * 1000
AS BIGINT)"
Review Comment:
This part is okay with me, and I have been aware of the timezone problem but
did not see it as a big problem as we can do the delete twice if we failed to
drop it in the first time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
