juiceyang commented on code in PR #9191:
URL: https://github.com/apache/gravitino/pull/9191#discussion_r2558378539
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/GravitinoCatalogManager.java:
##########
@@ -38,8 +38,15 @@ public class GravitinoCatalogManager {
private final GravitinoMetalake metalake;
private final GravitinoAdminClient gravitinoClient;
+ private final String gravitinoUri;
+ private final String metalakeName;
+ private final Map<String, String> gravitinoClientConfig;
+
private GravitinoCatalogManager(
String gravitinoUri, String metalakeName, Map<String, String>
gravitinoClientConfig) {
+ this.gravitinoUri = Preconditions.checkNotNull(gravitinoUri);
Review Comment:
I’ve updated the code style. It now uses Preconditions to validate
parameters first, and then assigns values to the variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
