yuqi1129 commented on code in PR #9160: URL: https://github.com/apache/gravitino/pull/9160#discussion_r2558783741
########## catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/generic/LakehouseTableDelegatorFactory.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog.lakehouse.generic; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableMap; +import java.util.Locale; +import java.util.Optional; +import java.util.ServiceLoader; +import java.util.stream.Collectors; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class LakehouseTableDelegatorFactory { + private static final Logger LOG = LoggerFactory.getLogger(LakehouseTableDelegatorFactory.class); + + private static ImmutableMap<String, LakehouseTableDelegator> delegators; + + private LakehouseTableDelegatorFactory() {} + + private static synchronized void createTableDelegators() { + if (delegators != null) { + return; + } + + ClassLoader cl = + Optional.ofNullable(Thread.currentThread().getContextClassLoader()) + .orElse(LakehouseTableDelegator.class.getClassLoader()); + ServiceLoader<LakehouseTableDelegator> loader = + ServiceLoader.load(LakehouseTableDelegator.class, cl); + delegators = + ImmutableMap.copyOf( + loader.stream() + .collect( + Collectors.toMap( + provider -> provider.get().tableFormat(), ServiceLoader.Provider::get))); + Preconditions.checkArgument( + !delegators.isEmpty(), + "No LakehouseTableDelegator implementation found via ServiceLoader, this is unexpected, " + + "please check the code to see what is going on."); Review Comment: Please format the comments ########## catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/lance/LanceTableOperations.java: ########## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog.lakehouse.lance; + +import com.google.common.base.Preconditions; +import com.lancedb.lance.Dataset; +import com.lancedb.lance.WriteParams; +import com.lancedb.lance.index.DistanceType; +import com.lancedb.lance.index.IndexParams; +import com.lancedb.lance.index.IndexType; +import com.lancedb.lance.index.vector.VectorIndexParams; +import java.util.Arrays; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.stream.Collectors; +import org.apache.arrow.memory.RootAllocator; +import org.apache.arrow.vector.types.pojo.Field; +import org.apache.commons.lang3.StringUtils; +import org.apache.gravitino.EntityStore; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.catalog.ManagedSchemaOperations; +import org.apache.gravitino.catalog.ManagedTableOperations; +import org.apache.gravitino.connector.SupportsSchemas; +import org.apache.gravitino.exceptions.NoSuchSchemaException; +import org.apache.gravitino.exceptions.NoSuchTableException; +import org.apache.gravitino.exceptions.TableAlreadyExistsException; +import org.apache.gravitino.lance.common.ops.gravitino.LanceDataTypeConverter; +import org.apache.gravitino.lance.common.utils.LancePropertiesUtils; +import org.apache.gravitino.rel.Column; +import org.apache.gravitino.rel.Table; +import org.apache.gravitino.rel.TableChange; +import org.apache.gravitino.rel.expressions.distributions.Distribution; +import org.apache.gravitino.rel.expressions.sorts.SortOrder; +import org.apache.gravitino.rel.expressions.transforms.Transform; +import org.apache.gravitino.rel.indexes.Index; +import org.apache.gravitino.rel.indexes.Indexes; +import org.apache.gravitino.storage.IdGenerator; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class LanceTableOperations extends ManagedTableOperations { + private static final Logger LOG = LoggerFactory.getLogger(LanceTableOperations.class); + + private final EntityStore store; + + private final ManagedSchemaOperations schemaOps; + + private final IdGenerator idGenerator; + + public LanceTableOperations( + EntityStore store, ManagedSchemaOperations schemaOps, IdGenerator idGenerator) { + this.store = store; + this.schemaOps = schemaOps; + this.idGenerator = idGenerator; + } + + @Override + protected EntityStore store() { + return store; + } + + @Override + protected SupportsSchemas schemas() { + return schemaOps; + } + + @Override + protected IdGenerator idGenerator() { + return idGenerator; + } + + @Override + public Table createTable( + NameIdentifier ident, + Column[] columns, + String comment, + Map<String, String> properties, + Transform[] partitions, + Distribution distribution, + SortOrder[] sortOrders, + Index[] indexes) + throws NoSuchSchemaException, TableAlreadyExistsException { + String location = properties.get(Table.PROPERTY_LOCATION); + Preconditions.checkArgument( + StringUtils.isNotBlank(location), "Table location must be specified"); + Map<String, String> storageProps = LancePropertiesUtils.getLanceStorageOptions(properties); + + boolean register = + Optional.ofNullable(properties.get(LanceTableDelegator.PROPERTY_LANCE_TABLE_REGISTER)) + .map(Boolean::parseBoolean) + .orElse(false); + if (register) { + // If this is a registration operation, just create the table metadata without creating a new + // dataset + return super.createTable( + ident, columns, comment, properties, partitions, distribution, sortOrders, indexes); + } + + try (Dataset ignored = + Dataset.create( + new RootAllocator(), + location, + convertColumnsToArrowSchema(columns), + new WriteParams.Builder().withStorageOptions(storageProps).build())) { + // Only create the table metadata in Gravitino after the Lance dataset is successfully + // created. + return super.createTable( + ident, columns, comment, properties, partitions, distribution, sortOrders, indexes); + } catch (NoSuchSchemaException e) { + throw e; + } catch (TableAlreadyExistsException e) { + // If the table metadata already exists, but the underlying lance table was just created + // successfully, we need to clean up the created lance table to avoid orphaned datasets. + Dataset.drop(location, LancePropertiesUtils.getLanceStorageOptions(properties)); + throw e; + } catch (IllegalArgumentException e) { + if (e.getMessage().contains("Dataset already exists")) { + throw new TableAlreadyExistsException( + e, "Lance dataset already exists at location %s", location); + } + throw e; + } catch (Exception e) { + throw new RuntimeException("Failed to create Lance dataset at location " + location, e); + } + } + + @Override + public Table alterTable(NameIdentifier ident, TableChange... changes) + throws NoSuchSchemaException, TableAlreadyExistsException { + // Lance only supports adding indexes for now. + boolean onlyAddIndex = + Arrays.stream(changes).allMatch(change -> change instanceof TableChange.AddIndex); + Preconditions.checkArgument(onlyAddIndex, "Only adding indexes is supported for Lance tables"); + + List<Index> addedIndexes = + Arrays.stream(changes) + .filter(change -> change instanceof TableChange.AddIndex) + .map( + change -> { + TableChange.AddIndex addIndexChange = (TableChange.AddIndex) change; + return Indexes.IndexImpl.builder() + .withIndexType(addIndexChange.getType()) + .withName(addIndexChange.getName()) + .withFieldNames(addIndexChange.getFieldNames()) + .build(); + }) + .collect(Collectors.toList()); + + Table loadedTable = super.loadTable(ident); + addLanceIndex(loadedTable, addedIndexes); + // After adding the index to the Lance dataset, we need to update the table metadata in + // Gravitino. If there's any failure during this process, the code will throw an exception + // and the update won't be applied in Gravitino. + return super.alterTable(ident, changes); + } + + @Override + public boolean purgeTable(NameIdentifier ident) { + try { + Table table = loadTable(ident); + String location = table.properties().get(Table.PROPERTY_LOCATION); + + boolean purged = super.purgeTable(ident); + // If the table metadata is purged successfully, we can delete the Lance dataset. + // Otherwise, we should not delete the dataset. + if (purged) { + // Delete the Lance dataset at the location + Dataset.drop(location, LancePropertiesUtils.getLanceStorageOptions(table.properties())); + LOG.info("Deleted Lance dataset at location {}", location); + } + + return purged; + + } catch (NoSuchTableException e) { + return false; + } catch (Exception e) { + throw new RuntimeException("Failed to purge Lance dataset for table " + ident, e); + } + } + + @Override + public boolean dropTable(NameIdentifier ident) { + try { + Table table = loadTable(ident); + boolean external = + Optional.ofNullable(table.properties().get(Table.PROPERTY_EXTERNAL)) + .map(Boolean::parseBoolean) + .orElse(false); + + boolean dropped = super.dropTable(ident); + if (external) { + return dropped; + } + + // If the table metadata is dropped successfully, and the table is not external, we can delete + // the + // Lance dataset. Otherwise, we should not delete the dataset. + if (dropped) { + String location = table.properties().get(Table.PROPERTY_LOCATION); + + // Delete the Lance dataset at the location + Dataset.drop(location, LancePropertiesUtils.getLanceStorageOptions(table.properties())); Review Comment: Do you need to catch possible exceptions here and then roll back entity store operation？ ########## catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/generic/LakehouseTableDelegatorFactory.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog.lakehouse.generic; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableMap; +import java.util.Locale; +import java.util.Optional; +import java.util.ServiceLoader; +import java.util.stream.Collectors; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class LakehouseTableDelegatorFactory { + private static final Logger LOG = LoggerFactory.getLogger(LakehouseTableDelegatorFactory.class); + + private static ImmutableMap<String, LakehouseTableDelegator> delegators; + + private LakehouseTableDelegatorFactory() {} + + private static synchronized void createTableDelegators() { + if (delegators != null) { + return; + } + + ClassLoader cl = + Optional.ofNullable(Thread.currentThread().getContextClassLoader()) + .orElse(LakehouseTableDelegator.class.getClassLoader()); + ServiceLoader<LakehouseTableDelegator> loader = + ServiceLoader.load(LakehouseTableDelegator.class, cl); + delegators = + ImmutableMap.copyOf( + loader.stream() + .collect( + Collectors.toMap( + provider -> provider.get().tableFormat(), ServiceLoader.Provider::get))); + Preconditions.checkArgument( + !delegators.isEmpty(), + "No LakehouseTableDelegator implementation found via ServiceLoader, this is unexpected, " + + "please check the code to see what is going on."); + + LOG.info("Loaded LakehouseTableDelegators: {}", delegators.keySet()); + } + + public static ImmutableMap<String, LakehouseTableDelegator> tableDelegators() { + // Initialize delegators if not yet done + createTableDelegators(); + return delegators; + } + + public static LakehouseTableDelegator tableDelegator(String format) { Review Comment: This method seems to be unused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
