yuqi1129 commented on code in PR #9097:
URL: https://github.com/apache/gravitino/pull/9097#discussion_r2563786527
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceTableOperations.java:
##########
@@ -192,13 +198,76 @@ public Response deregisterTable(
}
}
+ @POST
+ @Path("/create_index")
+ @Timed(name = "create-table-index." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "create-table-index", absolute = true)
+ public Response createTableIndex(
+ @PathParam("id") String tableId,
+ @QueryParam("delimiter") @DefaultValue(NAMESPACE_DELIMITER_DEFAULT)
String delimiter,
+ @Context HttpHeaders headers,
+ CreateTableIndexRequest createTableIndexRequest) {
+ try {
+ validateCreateTableIndexRequest(createTableIndexRequest);
+ CreateTableIndexResponse response =
+ lanceNamespace.asTableOps().createTableIndex(tableId, delimiter,
createTableIndexRequest);
+ return Response.ok(response).build();
+ } catch (Exception e) {
+ return LanceExceptionMapper.toRESTResponse(tableId, e);
+ }
+ }
+
+ @POST
+ @Path("/index/list")
+ @Timed(name = "list-table-indices." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "list-table-indices", absolute = true)
+ public Response listTableIndices(
+ @PathParam("id") String tableId,
+ @QueryParam("delimiter") @DefaultValue(NAMESPACE_DELIMITER_DEFAULT)
String delimiter,
+ @Context HttpHeaders headers,
+ ListTableIndicesRequest listTableIndicesRequest) {
+ try {
+ validateListTableIndicesRequest(listTableIndicesRequest);
+ ListTableIndicesResponse response =
+ lanceNamespace.asTableOps().listTableIndices(tableId, delimiter,
listTableIndicesRequest);
+ return Response.ok(response).build();
+ } catch (Exception e) {
+ return LanceExceptionMapper.toRESTResponse(tableId, e);
+ }
+ }
+
+ @POST
+ @Path("/index/{index_name}/stats")
+ @Timed(name = "describe-table-index." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "describe-table-index", absolute = true)
+ public Response describeTableIndex(
+ @PathParam("id") String tableId,
+ @PathParam("index_name") String indexName,
+ @QueryParam("delimiter") @DefaultValue(NAMESPACE_DELIMITER_DEFAULT)
String delimiter,
+ @Context HttpHeaders headers,
+ DescribeTableIndexStatsRequest describeTableIndexStatsRequest) {
+ try {
+ validateDescribeTableIndexRequest(describeTableIndexStatsRequest);
+ DescribeTableIndexStatsResponse response =
+ lanceNamespace
+ .asTableOps()
+ .describeTableIndexStats(
+ tableId, delimiter, indexName,
describeTableIndexStatsRequest);
+ return Response.ok(response).build();
+ } catch (Exception e) {
+ return LanceExceptionMapper.toRESTResponse(tableId, e);
+ }
+ }
Review Comment:
`describeTableIndexStats` is unsupported,please see
GravitinoLanceTableOperations#describeTableIndexStats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
