jerryshao commented on code in PR #9286:
URL: https://github.com/apache/gravitino/pull/9286#discussion_r2570352203
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java:
##########
@@ -365,7 +359,7 @@ private CloseableIterable<FileScanTask>
createFilePlanScanTasks(
return incrementalScan.planFiles();
} else {
TableScan tableScan = table.newScan();
- if (scanRequest.snapshotId() != null && scanRequest.snapshotId() != 0L) {
+ if (scanRequest.snapshotId() != null) {
Review Comment:
If so, I think you need to add the comment here to explain the reason here.
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java:
##########
@@ -365,7 +359,7 @@ private CloseableIterable<FileScanTask>
createFilePlanScanTasks(
return incrementalScan.planFiles();
} else {
TableScan tableScan = table.newScan();
- if (scanRequest.snapshotId() != null && scanRequest.snapshotId() != 0L) {
+ if (scanRequest.snapshotId() != null) {
Review Comment:
If so, I think you need to add the comment here to explain the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
