jerqi commented on code in PR #9283: URL: https://github.com/apache/gravitino/pull/9283#discussion_r2570900453
########## clients/client-java/src/test/java/org/apache/gravitino/client/integration/test/authorization/JobAuthorizationIT.java: ########## @@ -0,0 +1,335 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.client.integration.test.authorization; + +import static org.junit.jupiter.api.Assertions.assertThrows; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.ImmutableMap; +import com.google.common.collect.Lists; +import java.io.File; +import java.nio.file.Files; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import org.apache.commons.io.FileUtils; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.MetadataObjects; +import org.apache.gravitino.authorization.Privileges; +import org.apache.gravitino.client.GravitinoMetalake; +import org.apache.gravitino.exceptions.ForbiddenException; +import org.apache.gravitino.job.JobHandle; +import org.apache.gravitino.job.JobTemplate; +import org.apache.gravitino.job.ShellJobTemplate; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.MethodOrderer; +import org.junit.jupiter.api.Order; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestMethodOrder; + +@TestMethodOrder(MethodOrderer.OrderAnnotation.class) +public class JobAuthorizationIT extends BaseRestApiAuthorizationIT { + + private static File testStagingDir; + private static ShellJobTemplate.Builder builder; + private static final String ROLE = "job_test_role"; + + @BeforeAll + public void startIntegrationTest() throws Exception { + testStagingDir = Files.createTempDirectory("test_staging_dir").toFile(); + String testEntryScriptPath = generateTestEntryScript(); + String testLibScriptPath = generateTestLibScript(); + + builder = + ShellJobTemplate.builder() + .withComment("Test shell job template") + .withExecutable(testEntryScriptPath) + .withArguments(Lists.newArrayList("{{arg1}}", "{{arg2}}")) + .withEnvironments(ImmutableMap.of("ENV_VAR", "{{env_var}}")) + .withScripts(Lists.newArrayList(testLibScriptPath)) + .withCustomFields(Collections.emptyMap()); + + Map<String, String> configs = + ImmutableMap.of( + "gravitino.job.stagingDir", + testStagingDir.getAbsolutePath(), + "gravitino.job.statusPullIntervalInMs", + "3000"); + registerCustomConfigs(configs); + super.startIntegrationTest(); + + // Create role for authorization tests + GravitinoMetalake metalake = client.loadMetalake(METALAKE); + metalake.createRole(ROLE, new HashMap<>(), Collections.emptyList()); + metalake.grantRolesToUser(ImmutableList.of(ROLE), NORMAL_USER); + } + + @Test + @Order(1) + public void testRegisterJobTemplate() { + // User without privilege cannot register job template + assertThrows( + ForbiddenException.class, + () -> + normalUserClient + .loadMetalake(METALAKE) + .registerJobTemplate(builder.withName("test1").build())); + + // Grant privilege to normal user + GravitinoMetalake metalake = client.loadMetalake(METALAKE); + metalake.grantPrivilegesToRole( + ROLE, + MetadataObjects.of(null, METALAKE, MetadataObject.Type.METALAKE), + ImmutableList.of(Privileges.RegisterJobTemplate.allow())); + + // Now normal user can register job templates + JobTemplate template1 = builder.withName("test_1").build(); + JobTemplate template2 = builder.withName("test_2").build(); + normalUserClient.loadMetalake(METALAKE).registerJobTemplate(template1); + normalUserClient.loadMetalake(METALAKE).registerJobTemplate(template2); + + // Admin can always register job templates + JobTemplate template3 = builder.withName("test_3").build(); + metalake.registerJobTemplate(template3); + } + + @Test + @Order(2) + public void testListJobTemplates() { + // Normal user can see job templates they own (test_1, test_2) + List<JobTemplate> normalUserTemplates = + normalUserClient.loadMetalake(METALAKE).listJobTemplates(); + Assertions.assertEquals(2, normalUserTemplates.size()); + + // Admin can see all job templates (test_1, test_2, test_3) + List<JobTemplate> adminTemplates = client.loadMetalake(METALAKE).listJobTemplates(); + Assertions.assertEquals(3, adminTemplates.size()); + } + + @Test + @Order(3) + public void testGetJobTemplate() { + // Normal user can get their own job template + JobTemplate template = normalUserClient.loadMetalake(METALAKE).getJobTemplate("test_1"); + Assertions.assertNotNull(template); + Assertions.assertEquals("test_1", template.name()); + + // Normal user cannot get job template owned by admin + assertThrows( + ForbiddenException.class, + () -> normalUserClient.loadMetalake(METALAKE).getJobTemplate("test_3")); + + // Admin can get any job template + JobTemplate adminTemplate = client.loadMetalake(METALAKE).getJobTemplate("test_3"); + Assertions.assertNotNull(adminTemplate); + } + + @Test + @Order(4) + public void testDeleteJobTemplate() { + // Normal user cannot delete job template owned by admin + assertThrows( + ForbiddenException.class, + () -> normalUserClient.loadMetalake(METALAKE).deleteJobTemplate("test_3")); + + // Normal user can delete their own job template + boolean deleted = normalUserClient.loadMetalake(METALAKE).deleteJobTemplate("test_1"); + Assertions.assertTrue(deleted); + + // Admin can delete any job template + boolean adminDeleted = client.loadMetalake(METALAKE).deleteJobTemplate("test_3"); + Assertions.assertTrue(adminDeleted); + } + + @Test + @Order(5) + public void testCreateJob() { Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
