Copilot commented on code in PR #9299:
URL: https://github.com/apache/gravitino/pull/9299#discussion_r2571685953
##########
lance/lance-common/src/main/java/org/apache/gravitino/lance/common/ops/gravitino/GravitinoLanceTableOperations.java:
##########
@@ -128,8 +131,8 @@ public CreateTableResponse createTable(
createTableProperties.put(LANCE_LOCATION, tableLocation);
}
// The format is defined in GenericLakehouseCatalog
- createTableProperties.put(Table.PROPERTY_TABLE_FORMAT, "lance");
- createTableProperties.put(Table.PROPERTY_EXTERNAL, "true");
+ createTableProperties.put(PROPERTY_TABLE_FORMAT, "lance");
Review Comment:
For consistency with the `registerTable` method (line 212) which uses the
`LANCE_TABLE_FORMAT` constant, consider using the constant here instead of the
hardcoded string "lance". This would make the code more maintainable and
consistent.
```java
createTableProperties.put(PROPERTY_TABLE_FORMAT, LANCE_TABLE_FORMAT);
```
```suggestion
createTableProperties.put(PROPERTY_TABLE_FORMAT, LANCE_TABLE_FORMAT);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
