Copilot commented on code in PR #9129:
URL: https://github.com/apache/gravitino/pull/9129#discussion_r2575518521
##########
flink-connector/flink/src/test/java/org/apache/gravitino/flink/connector/utils/TestTypeUtils.java:
##########
@@ -93,11 +93,15 @@ public void testToGravitinoType() {
Assertions.assertEquals(
Types.MapType.of(Types.StringType.get(), Types.IntegerType.get(),
true),
TypeUtils.toGravitinoType(
- new MapType(true, new VarCharType(Integer.MAX_VALUE), new
IntType())));
+ new MapType(true, new VarCharType(Integer.MAX_VALUE), new
IntType(true))));
Assertions.assertEquals(
Types.MapType.of(Types.StringType.get(), Types.IntegerType.get(),
false),
TypeUtils.toGravitinoType(
- new MapType(false, new VarCharType(Integer.MAX_VALUE), new
IntType())));
+ new MapType(true, new VarCharType(Integer.MAX_VALUE), new
IntType(false))));
+ Assertions.assertEquals(
+ Types.MapType.of(Types.StringType.get(), Types.IntegerType.get(),
false),
+ TypeUtils.toGravitinoType(
+ new MapType(false, new VarCharType(Integer.MAX_VALUE), new
IntType(false))));
Review Comment:
The test coverage for map type conversions is missing a test case where the
map itself is not nullable but the value type is nullable. Consider adding a
test case for `new MapType(false, new VarCharType(Integer.MAX_VALUE), new
IntType(true))` which should produce `Types.MapType.of(Types.StringType.get(),
Types.IntegerType.get(), true)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
