diqiu50 commented on code in PR #8777:
URL: https://github.com/apache/gravitino/pull/8777#discussion_r2575802339
##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/BaseGVFSOperations.java:
##########
@@ -867,20 +955,19 @@ private Cache<FileSystemCacheKey, FileSystem>
newFileSystemCache(Configuration c
}
private Map<String, String> getAllProperties(
- NameIdentifier filesetIdent, String scheme, String locationName) {
+ NameIdentifier filesetIdent, Map<String, String> filesetProperties) {
+ Map<String, String> allProperties = new HashMap<>();
Catalog catalog =
(Catalog)
getFilesetCatalog(
NameIdentifier.of(
filesetIdent.namespace().level(0),
filesetIdent.namespace().level(1)));
+ allProperties.putAll(catalog.properties());
- Map<String, String> allProperties =
getNecessaryProperties(catalog.properties());
- allProperties.putAll(getConfigMap(conf));
- if (enableCredentialVending()) {
- allProperties.putAll(
- getCredentialProperties(
- getFileSystemProviderByScheme(scheme), filesetIdent,
locationName));
- }
+ Schema schema =
getSchema(NameIdentifier.parse(filesetIdent.namespace().toString()));
+ allProperties.putAll(schema.properties());
+ allProperties.putAll(filesetProperties);
Review Comment:
Add new issue: https://github.com/apache/gravitino/issues/9312
##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/BaseGVFSOperations.java:
##########
@@ -867,20 +955,19 @@ private Cache<FileSystemCacheKey, FileSystem>
newFileSystemCache(Configuration c
}
private Map<String, String> getAllProperties(
- NameIdentifier filesetIdent, String scheme, String locationName) {
+ NameIdentifier filesetIdent, Map<String, String> filesetProperties) {
+ Map<String, String> allProperties = new HashMap<>();
Catalog catalog =
(Catalog)
getFilesetCatalog(
NameIdentifier.of(
filesetIdent.namespace().level(0),
filesetIdent.namespace().level(1)));
+ allProperties.putAll(catalog.properties());
- Map<String, String> allProperties =
getNecessaryProperties(catalog.properties());
- allProperties.putAll(getConfigMap(conf));
- if (enableCredentialVending()) {
- allProperties.putAll(
- getCredentialProperties(
- getFileSystemProviderByScheme(scheme), filesetIdent,
locationName));
- }
+ Schema schema =
getSchema(NameIdentifier.parse(filesetIdent.namespace().toString()));
+ allProperties.putAll(schema.properties());
+ allProperties.putAll(filesetProperties);
Review Comment:
Add a new issue: https://github.com/apache/gravitino/issues/9312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
