jerryshao commented on code in PR #9284:
URL: https://github.com/apache/gravitino/pull/9284#discussion_r2575829337
##########
clients/client-python/gravitino/dto/job/spark_job_template_dto.py:
##########
@@ -27,7 +27,12 @@
@register_job_template(JobType.SPARK)
@dataclass
class SparkJobTemplateDTO(JobTemplateDTO):
- """Represents a Spark Job Template Data Transfer Object (DTO)."""
+ """
+ Represents a Spark Job Template Data Transfer Object (DTO).
+
+ Note: The class_name field is required for Java/Scala Spark applications
but is
+ optional for PySpark applications. For PySpark jobs, this field can be
None.
+ """
_class_name: str = field(default=None,
metadata=config(field_name="className"))
Review Comment:
It is not so necesary, but I can fix it.
##########
clients/client-python/gravitino/dto/job/spark_job_template_dto.py:
##########
@@ -27,7 +27,12 @@
@register_job_template(JobType.SPARK)
@dataclass
class SparkJobTemplateDTO(JobTemplateDTO):
- """Represents a Spark Job Template Data Transfer Object (DTO)."""
+ """
+ Represents a Spark Job Template Data Transfer Object (DTO).
+
+ Note: The class_name field is required for Java/Scala Spark applications
but is
+ optional for PySpark applications. For PySpark jobs, this field can be
None.
+ """
_class_name: str = field(default=None,
metadata=config(field_name="className"))
Review Comment:
It is not so necessary, but I can fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
