Copilot commented on code in PR #9319:
URL: https://github.com/apache/gravitino/pull/9319#discussion_r2579303067
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalog.java:
##########
@@ -203,7 +204,8 @@ public List<String> listTables(String databaseName)
@Override
public List<String> listViews(String s) throws DatabaseNotExistException,
CatalogException {
Review Comment:
The parameter name `s` is not descriptive. According to the method
signature, this should be named `databaseName` to match the convention used in
other methods like `listTables(String databaseName)` on line 192. Consider
renaming it for consistency and clarity.
```suggestion
public List<String> listViews(String databaseName) throws
DatabaseNotExistException, CatalogException {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
