diqiu50 commented on code in PR #9316:
URL: https://github.com/apache/gravitino/pull/9316#discussion_r2579448948
##########
build.gradle.kts:
##########
@@ -1181,5 +1181,13 @@ tasks.register("release") {
println("Releasing project...")
}
- dependsOn(subprojects.map { it.tasks.named("build") })
+ // Use 'assemble' instead of 'build' to skip tests during release
+ // Tests have JDK version conflicts (some need JDK 8, some need JDK 17)
+ // and should be run separately in CI/CD with appropriate JDK configurations
+ // Only include subprojects that apply the Java plugin (exclude
client-python)
+ dependsOn(
+ subprojects
+ .filter { it.name != "client-python" }
+ .map { it.tasks.named("assemble") }
+ )
Review Comment:
Ultimately, we want `./gradlew build` to produce packages for the client and
other modules that are compatible with JDK 8.
##########
build.gradle.kts:
##########
@@ -1181,5 +1181,13 @@ tasks.register("release") {
println("Releasing project...")
}
- dependsOn(subprojects.map { it.tasks.named("build") })
+ // Use 'assemble' instead of 'build' to skip tests during release
+ // Tests have JDK version conflicts (some need JDK 8, some need JDK 17)
+ // and should be run separately in CI/CD with appropriate JDK configurations
+ // Only include subprojects that apply the Java plugin (exclude
client-python)
+ dependsOn(
+ subprojects
+ .filter { it.name != "client-python" }
+ .map { it.tasks.named("assemble") }
+ )
Review Comment:
Ultimately, we want `./gradlew build` to produce packages for the client and
other modules that are compatible with JDK 8. However, because some client
modules have integration tests that depend on the core/server modules (built
with JDK 17), the build fails. This is why we introduced the command ./gradlew
release -x test. This issue is intended to resolve that problem, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
