Copilot commented on code in PR #9292:
URL: https://github.com/apache/gravitino/pull/9292#discussion_r2584783252
##########
dev/charts/gravitino-iceberg-rest-server/templates/poddisruptionbudget.yaml:
##########
@@ -0,0 +1,49 @@
+{{- /*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */}}
+
+{{- if .Values.podDisruptionBudget.enabled }}
+{{- if and .Values.podDisruptionBudget.minAvailable
.Values.podDisruptionBudget.maxUnavailable }}
Review Comment:
The validation logic will not properly detect when both `minAvailable` and
`maxUnavailable` are set if `minAvailable: 0` is used. A value of 0 is valid
for `minAvailable` (though unusual) but is falsy in Go templates, causing the
validation to incorrectly pass.
Consider using a more explicit check:
```yaml
{{- if and (or .Values.podDisruptionBudget.minAvailable (eq
(.Values.podDisruptionBudget.minAvailable | int) 0)) (ne
.Values.podDisruptionBudget.maxUnavailable "") }}
```
or check if the fields are defined rather than truthy:
```yaml
{{- if and (hasKey .Values.podDisruptionBudget "minAvailable") (ne
.Values.podDisruptionBudget.maxUnavailable "") }}
```
```suggestion
{{- if and (hasKey .Values.podDisruptionBudget "minAvailable") (ne
.Values.podDisruptionBudget.maxUnavailable "") }}
```
##########
dev/charts/gravitino/templates/poddisruptionbudget.yaml:
##########
@@ -0,0 +1,49 @@
+{{- /*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */}}
+
+{{- if .Values.podDisruptionBudget.enabled }}
+{{- if and .Values.podDisruptionBudget.minAvailable
.Values.podDisruptionBudget.maxUnavailable }}
Review Comment:
The validation logic will not properly detect when both `minAvailable` and
`maxUnavailable` are set if `minAvailable: 0` is used. A value of 0 is valid
for `minAvailable` (though unusual) but is falsy in Go templates, causing the
validation to incorrectly pass.
Consider using a more explicit check:
```yaml
{{- if and (or .Values.podDisruptionBudget.minAvailable (eq
(.Values.podDisruptionBudget.minAvailable | int) 0)) (ne
.Values.podDisruptionBudget.maxUnavailable "") }}
```
or check if the fields are defined rather than truthy:
```yaml
{{- if and (hasKey .Values.podDisruptionBudget "minAvailable") (ne
.Values.podDisruptionBudget.maxUnavailable "") }}
```
```suggestion
{{- if and (hasKey .Values.podDisruptionBudget "minAvailable") (ne
.Values.podDisruptionBudget.maxUnavailable "") }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
