jerryshao commented on code in PR #9282:
URL: https://github.com/apache/gravitino/pull/9282#discussion_r2587842170
##########
bundles/aliyun/src/main/java/org/apache/gravitino/oss/fs/OSSFileSystemProvider.java:
##########
@@ -80,6 +82,25 @@ public Map<String, String>
getFileSystemCredentialConf(Credential[] credentials)
return result;
}
+ private Map<String, String> additionalOSSConfig(Map<String, String> configs)
{
+ Map<String, String> additionalConfigs = Maps.newHashMap(configs);
+
+ // Avoid multiple retries to speed up failure in test cases.
+ // Use hard code instead of Constants.ESTABLISH_TIMEOUT_KEY to avoid
dependency on a specific
+ // Hadoop version.
+ if (!configs.containsKey("fs.oss.connection.establish.timeout")) {
+ additionalConfigs.put("fs.oss.connection.establish.timeout", "5000");
+ }
+
+ if (!configs.containsKey("fs.oss.attempts.maximum")) {
+ additionalConfigs.put("fs.oss.attempts.maximum", "2");
+ }
Review Comment:
I think you can define all the conf keys and values in the hadoop-common or
catalog-common module, which is easy to maintain and update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
