This is an automated email from the ASF dual-hosted git repository.
fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 9c15945e5d [#9390] improvment(lance-rest): Unified Lance REST
configurations format with Iceberg REST (#9394)
9c15945e5d is described below
commit 9c15945e5d96b654b4b431229a542bd0626ff1d8
Author: Mini Yu <[email protected]>
AuthorDate: Mon Dec 8 09:53:53 2025 +0800
[#9390] improvment(lance-rest): Unified Lance REST configurations format
with Iceberg REST (#9394)
### What changes were proposed in this pull request?
Change configuration:
- `gravitino.lance-rest.gravitino.uri` to
`gravitino.lance-rest.gravitino-uri`
- `gravitino.lance-rest.gravitino.metalake` to
`gravitino.lance-rest.gravitino-metalake`
### Why are the changes needed?
To make the format consistent with that in Iceberg REST.
Fix: #9390
### Does this PR introduce _any_ user-facing change?
Yes，but Lance REST has not been released yet, so it's free to do so.
### How was this patch tested?
UTs and ITs
---
conf/gravitino-lance-rest-server.conf.template | 4 ++--
conf/gravitino.conf.template | 4 ++--
dev/docker/lance-rest-server/rewrite_config.py | 8 ++++----
docs/docker-image-details.md | 2 +-
.../org/apache/gravitino/lance/common/config/LanceConfig.java | 6 +++---
5 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/conf/gravitino-lance-rest-server.conf.template
b/conf/gravitino-lance-rest-server.conf.template
index d74fec3eb7..b8e1d0b1e1 100644
--- a/conf/gravitino-lance-rest-server.conf.template
+++ b/conf/gravitino-lance-rest-server.conf.template
@@ -44,6 +44,6 @@ gravitino.lance-rest.responseHeaderSize = 131072
# The backend Lance namespace for Lance REST service, it's recommended to use
Gravitino
gravitino.lance-rest.namespace-backend = gravitino
# The uri of the Lance REST service gravitino namespace backend
-gravitino.lance-rest.gravitino.uri = http://localhost:8090
+gravitino.lance-rest.gravitino-uri = http://localhost:8090
# The metalake name used for Lance REST service gravitino namespace backend,
please create the metalake before using it, and configure the metalake name
here.
-# gravitino.lance-rest.gravitino.metalake-name = metalake
+# gravitino.lance-rest.gravitino-metalake = metalake
diff --git a/conf/gravitino.conf.template b/conf/gravitino.conf.template
index f3af89c12b..c1210100d9 100644
--- a/conf/gravitino.conf.template
+++ b/conf/gravitino.conf.template
@@ -105,6 +105,6 @@ gravitino.lance-rest.httpPort = 9101
# The backend Lance namespace for Lance REST service, it's recommended to use
Gravitino
gravitino.lance-rest.namespace-backend = gravitino
# The uri of the Lance REST service gravitino namespace backend
-gravitino.lance-rest.gravitino.uri = http://localhost:8090
+gravitino.lance-rest.gravitino-uri = http://localhost:8090
# The metalake name used for Lance REST service gravitino namespace backend,
please create the metalake first before using it, and configure the metalake
name here.
-# gravitino.lance-rest.gravitino.metalake-name = metalake
+# gravitino.lance-rest.gravitino.metalake = metalake
diff --git a/dev/docker/lance-rest-server/rewrite_config.py
b/dev/docker/lance-rest-server/rewrite_config.py
index b165b0faa1..4bc26e8796 100755
--- a/dev/docker/lance-rest-server/rewrite_config.py
+++ b/dev/docker/lance-rest-server/rewrite_config.py
@@ -20,16 +20,16 @@ import os
env_map = {
"LANCE_REST_NAMESPACE_BACKEND": "namespace-backend",
- "LANCE_REST_GRAVITINO_URI": "gravitino.uri",
- "LANCE_REST_GRAVITINO_METALAKE_NAME": "gravitino.metalake-name",
+ "LANCE_REST_GRAVITINO_URI": "gravitino-uri",
+ "LANCE_REST_GRAVITINO_METALAKE_NAME": "gravitino-metalake",
"LANCE_REST_HOST": "host",
"LANCE_REST_PORT": "httpPort"
}
init_config = {
"namespace-backend": "gravitino",
- "gravitino.uri": "http://localhost:8090";,
- "gravitino.metalake-name": "metalake",
+ "gravitino-uri": "http://localhost:8090";,
+ "gravitino-metalake": "metalake",
"host": "0.0.0.0",
"httpPort": "9101"
}
diff --git a/docs/docker-image-details.md b/docs/docker-image-details.md
index 9f67aff561..281e597256 100644
--- a/docs/docker-image-details.md
+++ b/docs/docker-image-details.md
@@ -142,7 +142,7 @@ Memory settings
Use `GRAVITINO_MEM` to size the JVM (default `-Xms1024m -Xmx1024m
-XX:MaxMetaspaceSize=512m`). Example: `-e GRAVITINO_MEM="-Xms2g -Xmx2g
-XX:MaxMetaspaceSize=512m"`. Launch scripts append `GRAVITINO_MEM` to
`JAVA_OPTS`, so set it whenever you need different heap/metaspace sizes.
Currently, Gravitino Lance REST server supports setting the following
environment variables
-- LANCE_REST_GRAVITINO_METALAKE_NAME: It will overwrite the configuration
"gravitino.lance-rest.gravitino.metalake-name" in configuration file
`conf/gravitino-lance-rest-server.conf`. **You should set it to your Gravitino
metalake name.**
+- LANCE_REST_GRAVITINO_METALAKE_NAME: It will overwrite the configuration
"gravitino.lance-rest.gravitino-metalake" in configuration file
`conf/gravitino-lance-rest-server.conf`. **You should set it to your Gravitino
metalake name.**
- LANCE_REST_NAMESPACE_BACKEND: It will overwrite the configuration
"gravitino.lance-rest.namespace-backend" in configuration file
`conf/gravitino-lance-rest-server.conf`. The default value is "gravitino" and
you should not change it as of now.
- LANCE_REST_GRAVITINO_URI: It will overwrite the configuration
"gravitino.lance-rest.gravitino-uri" in configuration file
`conf/gravitino-lance-rest-server.conf`. The default value is
"http://localhost:8090"; and you can change it to your Gravitino server address.
- LANCE_REST_HOST: It will overwrite the configuration
"gravitino.lance-rest.host" in configuration file
`conf/gravitino-lance-rest-server.conf`. The default value is `0.0.0.0`.
diff --git
a/lance/lance-common/src/main/java/org/apache/gravitino/lance/common/config/LanceConfig.java
b/lance/lance-common/src/main/java/org/apache/gravitino/lance/common/config/LanceConfig.java
index 28fb09fb1f..ccf1f0dc07 100644
---
a/lance/lance-common/src/main/java/org/apache/gravitino/lance/common/config/LanceConfig.java
+++
b/lance/lance-common/src/main/java/org/apache/gravitino/lance/common/config/LanceConfig.java
@@ -31,7 +31,7 @@ public class LanceConfig extends Config implements
OverwriteDefaultConfig {
public static final String LANCE_CONFIG_PREFIX = "gravitino.lance-rest.";
public static final String CONFIG_NAMESPACE_BACKEND = "namespace-backend";
- public static final String CONFIG_METALAKE = "metalake-name";
+ public static final String CONFIG_METALAKE = "metalake";
public static final String CONFIG_URI = "uri";
public static final int DEFAULT_LANCE_REST_SERVICE_HTTP_PORT = 9101;
@@ -47,14 +47,14 @@ public class LanceConfig extends Config implements
OverwriteDefaultConfig {
.createWithDefault(GRAVITINO_NAMESPACE_BACKEND);
public static final ConfigEntry<String> METALAKE_NAME =
- new ConfigBuilder(GRAVITINO_NAMESPACE_BACKEND + "." + CONFIG_METALAKE)
+ new ConfigBuilder(GRAVITINO_NAMESPACE_BACKEND + "-" + CONFIG_METALAKE)
.doc("The Metalake name for Lance Gravitino namespace backend")
.version(ConfigConstants.VERSION_1_1_0)
.stringConf()
.create();
public static final ConfigEntry<String> NAMESPACE_BACKEND_URI =
- new ConfigBuilder(GRAVITINO_NAMESPACE_BACKEND + "." + CONFIG_URI)
+ new ConfigBuilder(GRAVITINO_NAMESPACE_BACKEND + "-" + CONFIG_URI)
.doc("The URI of the namespace backend, e.g., Gravitino server URI")
.version(ConfigConstants.VERSION_1_1_0)
.stringConf()
