(gravitino) branch main updated: [#9307] improvement(server): a missing partition will cause sever error (#9397)

[mchades]

This is an automated email from the ASF dual-hosted git repository.

mchades pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 484fb766c1 [#9307] improvement(server): a missing partition will cause 
sever error (#9397)
484fb766c1 is described below

commit 484fb766c11521c099bd0da1f12954ff233a24ae
Author: Salmane Khalili <salmajo2...@gmail.com>
AuthorDate: Mon Dec 8 04:22:29 2025 +0100

    [#9307] improvement(server): a missing partition will cause sever error 
(#9397)
    
    ### What changes were proposed in this pull request?
    
    Introduced a null check in the addPartitions resource method within
    PartitionOperations.java, It throws IllegalArgumentException, expanded
    the try scope to cover the check as well.
    A new unit test, testAddPartitionWithNullPartitions(), for fix
    validation.
    
    
    ### Why are the changes needed?
    
    Currently, if the request or its partition are null, the result is an
    NPE, it bypassed the intended error mapping logic and was treated as an
    unexpected server error, resulting in an 500 Internal Server Error
    response.
    
    Fix: #9307
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    
    Added testAddPartitionWithNullPartitions() to test suit and executed
    these:
     ./gradlew :common:compileJava
    ./gradlew :common:test
    ./gradlew :server:test
    All builds/tests were successful.
---
 .../server/web/rest/PartitionOperations.java       | 25 ++++++++++++----------
 .../server/web/rest/TestPartitionOperations.java   | 19 ++++++++++++++++
 2 files changed, 33 insertions(+), 11 deletions(-)

diff --git 
a/server/src/main/java/org/apache/gravitino/server/web/rest/PartitionOperations.java
 
b/server/src/main/java/org/apache/gravitino/server/web/rest/PartitionOperations.java
index b4bf0eeed4..654f401e33 100644
--- 
a/server/src/main/java/org/apache/gravitino/server/web/rest/PartitionOperations.java
+++ 
b/server/src/main/java/org/apache/gravitino/server/web/rest/PartitionOperations.java
@@ -180,19 +180,22 @@ public class PartitionOperations {
       @PathParam("schema") @AuthorizationMetadata(type = 
Entity.EntityType.SCHEMA) String schema,
       @PathParam("table") @AuthorizationMetadata(type = 
Entity.EntityType.TABLE) String table,
       AddPartitionsRequest request) {
-    LOG.info(
-        "Received add {} partition(s) request for table {}.{}.{}.{} ",
-        request.getPartitions().length,
-        metalake,
-        catalog,
-        schema,
-        table);
-    Preconditions.checkArgument(
-        request.getPartitions().length == 1, "Only one partition is 
supported");
+    try {
+      if (request == null || request.getPartitions() == null) {
+        throw new IllegalArgumentException("partitions must not be null");
+      }
+      LOG.info(
+          "Received add {} partition(s) request for table {}.{}.{}.{} ",
+          request.getPartitions().length,
+          metalake,
+          catalog,
+          schema,
+          table);
+      Preconditions.checkArgument(
+          request.getPartitions().length == 1, "Only one partition is 
supported");
 
-    request.validate();
+      request.validate();
 
-    try {
       return Utils.doAs(
           httpRequest,
           () -> {
diff --git 
a/server/src/test/java/org/apache/gravitino/server/web/rest/TestPartitionOperations.java
 
b/server/src/test/java/org/apache/gravitino/server/web/rest/TestPartitionOperations.java
index 05b2a8e491..ea3dd7ec61 100644
--- 
a/server/src/test/java/org/apache/gravitino/server/web/rest/TestPartitionOperations.java
+++ 
b/server/src/test/java/org/apache/gravitino/server/web/rest/TestPartitionOperations.java
@@ -326,4 +326,23 @@ public class TestPartitionOperations extends JerseyTest {
     Assertions.assertEquals(0, noExistDropResponse.getCode());
     Assertions.assertFalse(noExistDropResponse.dropped());
   }
+
+  @Test
+  public void testAddPartitionWithNullPartitions() {
+    AddPartitionsRequest invalidReq = new AddPartitionsRequest();
+
+    Response resp =
+        target(partitionPath(metalake, catalog, schema, table))
+            .request(MediaType.APPLICATION_JSON_TYPE)
+            .accept("application/vnd.gravitino.v1+json")
+            .post(Entity.entity(invalidReq, MediaType.APPLICATION_JSON_TYPE));
+
+    Assertions.assertEquals(Response.Status.BAD_REQUEST.getStatusCode(), 
resp.getStatus());
+
+    ErrorResponse errorResponse = resp.readEntity(ErrorResponse.class);
+    Assertions.assertEquals(ErrorConstants.ILLEGAL_ARGUMENTS_CODE, 
errorResponse.getCode());
+    Assertions.assertEquals(
+        IllegalArgumentException.class.getSimpleName(), 
errorResponse.getType());
+    Assertions.assertTrue(errorResponse.getMessage().contains("partitions must 
not be null"));
+  }
 }