LongerDude commented on code in PR #9412:
URL: https://github.com/apache/gravitino/pull/9412#discussion_r2602211170
##########
lineage/src/main/java/org/apache/gravitino/lineage/sink/LineageSinkManager.java:
##########
@@ -79,7 +79,9 @@ private static Map<String, String>
generateEventListenerConfigs(
String queueCapacity =
lineageConfigs.get(LineageConfig.LINEAGE_SINK_QUEUE_CAPACITY);
Preconditions.checkArgument(
StringUtils.isNotBlank(queueCapacity), "Lineage sink queue capacity is
not set");
- int capacityPerSink = Integer.valueOf(queueCapacity) / sinks.size();
+
+ int totalCapacity = Integer.parseInt(queueCapacity);
Review Comment:
@FANNG1 concerning this suggestion, my code implicitily handes configuration
of 0. but it seems like copilot is suggesting i make it an illegal state and
force the user to set a value thats larger than 0.
which is preferred? fail fast or soft handle it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
