mchades commented on code in PR #9446:
URL: https://github.com/apache/gravitino/pull/9446#discussion_r2608867689
##########
catalogs/hive-metastore-common/src/main/java/org/apache/gravitino/hive/client/Util.java:
##########
@@ -27,9 +27,9 @@ public class Util {
public static final String HIVE_CONFIG_RESOURCES = "hive.config.resources";
- public static Configuration buildConfigurationFromProperties(Properties
properties) {
+ public static Configuration buildConfigurationFromProperties(
+ Properties properties, Configuration config) {
Review Comment:
This method's behavior is still very strange; it modifies the input
parameters (without a copy) and returns them. It is recommended not to modify
the input parameters (copy before modify) or return void.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
