diqiu50 commented on code in PR #9458:
URL: https://github.com/apache/gravitino/pull/9458#discussion_r2609424309
##########
catalogs/hive-metastore-common/src/main/java/org/apache/gravitino/hive/client/HiveClientFactory.java:
##########
@@ -169,7 +185,22 @@ private HiveClient
createHiveClientInternal(HiveClientClassLoader classloader) {
ClassLoader origLoader = Thread.currentThread().getContextClassLoader();
Thread.currentThread().setContextClassLoader(classloader);
try {
- return createHiveClientImpl(classloader.getHiveVersion(), properties,
classloader);
+ if (!enableImpersonation) {
Review Comment:
fixed
##########
catalogs/hive-metastore-common/src/main/java/org/apache/gravitino/hive/client/HiveClientFactory.java:
##########
@@ -169,7 +185,22 @@ private HiveClient
createHiveClientInternal(HiveClientClassLoader classloader) {
ClassLoader origLoader = Thread.currentThread().getContextClassLoader();
Thread.currentThread().setContextClassLoader(classloader);
try {
- return createHiveClientImpl(classloader.getHiveVersion(), properties,
classloader);
+ if (!enableImpersonation) {
+ return createHiveClientImpl(classloader.getHiveVersion(), properties,
classloader);
+ } else {
+ UserGroupInformation ugi;
+ if (!enableKerberos) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
