mchades commented on code in PR #9460:
URL: https://github.com/apache/gravitino/pull/9460#discussion_r2610217194
##########
catalogs/catalog-hive/src/test/java/org/apache/gravitino/catalog/hive/TestHiveCatalogOperations.java:
##########
@@ -53,27 +54,12 @@
import org.junit.jupiter.api.Test;
class TestHiveCatalogOperations {
- @Test
- void testInitialize() {
- Map<String, String> properties = Maps.newHashMap();
- HiveCatalogOperations hiveCatalogOperations = new HiveCatalogOperations();
- hiveCatalogOperations.initialize(properties, null,
HIVE_PROPERTIES_METADATA);
- String v = hiveCatalogOperations.hiveConf.get("mapreduce.job.reduces");
- Assertions.assertEquals("10", v);
-
- // Test If we can override the value in hive-site.xml
- properties.put(CATALOG_BYPASS_PREFIX + "mapreduce.job.reduces", "20");
- hiveCatalogOperations.initialize(properties, null,
HIVE_PROPERTIES_METADATA);
- v = hiveCatalogOperations.hiveConf.get("mapreduce.job.reduces");
- Assertions.assertEquals("20", v);
- }
-
@Test
void testPropertyMeta() {
Map<String, PropertyEntry<?>> propertyEntryMap =
HIVE_PROPERTIES_METADATA.catalogPropertiesMetadata().propertyEntries();
- Assertions.assertEquals(16, propertyEntryMap.size());
+ Assertions.assertEquals(17, propertyEntryMap.size());
Review Comment:
plz also assert the new default property value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
