Copilot commented on code in PR #9466:
URL: https://github.com/apache/gravitino/pull/9466#discussion_r2610272841
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/TableMetaService.java:
##########
@@ -289,7 +289,7 @@ public boolean deleteTable(NameIdentifier identifier) {
mapper ->
mapper.softDeletePolicyMetadataObjectRelsByTableId(
namespacedEntityId.entityId()));
- SessionUtils.doWithCommit(
+ SessionUtils.doWithoutCommit(
Review Comment:
Good fix! This change correctly ensures transaction atomicity within the
doMultipleWithCommit block. However, the same issue exists in two other places
in this file:
1. Line 140 in the insertTable method - doWithCommit is used within
doMultipleWithCommit for TableVersionMapper
2. Line 214 in the updateTable method - doWithCommit is used within
doMultipleWithCommit for TableVersionMapper
These should also be changed to doWithoutCommit to prevent the same
transaction rollback issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
