yuqi1129 commented on code in PR #9467:
URL: https://github.com/apache/gravitino/pull/9467#discussion_r2610571848
##########
core/src/main/java/org/apache/gravitino/utils/NameIdentifierUtil.java:
##########
@@ -731,4 +733,101 @@ public static Entity.EntityType
parentEntityType(Entity.EntityType type) {
throw new IllegalArgumentException("Metalake has no parent entity
type");
}
}
+
+ /**
+ * Build a NameIdentifier for the given entity type and name, using the
provided entity context.
+ * This method constructs the identifier hierarchically using the parent
entity type
+ * relationships.
+ *
+ * @param type The entity type
+ * @param name The entity name
+ * @param entities Map containing the metalake, catalog, schema names
+ * @return The created NameIdentifier
+ * @throws IllegalArgumentException if the entity type is not supported or
required parent
+ * entities are missing
+ */
+ public static NameIdentifier buildNameIdentifier(
Review Comment:
Could you add an example input and the result in the comments? There is no
UT to cover it and it's hard to understand the code logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
