mchades commented on code in PR #9460:
URL: https://github.com/apache/gravitino/pull/9460#discussion_r2612847413
##########
catalogs/catalog-lakehouse-hudi/src/main/java/org/apache/gravitino/catalog/lakehouse/hudi/backend/hms/HudiHMSTable.java:
##########
@@ -60,25 +56,31 @@ protected HudiHMSTable simpleBuild() {
@Override
protected HudiHMSTable buildFromTable(Table hmsTable) {
- name = hmsTable.getTableName();
- comment = hmsTable.getParameters().get(COMMENT);
- columns = HiveTableConverter.getColumns(hmsTable, HudiColumn.builder());
- partitioning = HiveTableConverter.getPartitioning(hmsTable);
-
- // Should always be SortOrders.NONE since Hudi using clustering to sort
data (see
- // https://hudi.apache.org/docs/next/clustering/)
- // but is run as a background table service
Review Comment:
why remove these comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
