jerqi commented on code in PR #9467:
URL: https://github.com/apache/gravitino/pull/9467#discussion_r2614082874
##########
server/src/main/java/org/apache/gravitino/server/web/filter/ParameterUtil.java:
##########
@@ -65,149 +67,67 @@ public static Object extractFromParameters(Parameter[]
parameters, Object[] args
public static Map<Entity.EntityType, NameIdentifier>
extractNameIdentifierFromParameters(
Parameter[] parameters, Object[] args) {
- Map<Entity.EntityType, String> entities = new HashMap<>();
- Map<Entity.EntityType, NameIdentifier> nameIdentifierMap = new HashMap<>();
- // Extract AuthorizationMetadata
- for (int i = 0; i < parameters.length; i++) {
- Parameter parameter = parameters[i];
- AuthorizationMetadata authorizeResource =
- parameter.getAnnotation(AuthorizationMetadata.class);
- if (authorizeResource == null) {
- continue;
+ Map<Entity.EntityType, String> entities =
extractEntitiesFromAnnotations(parameters, args);
+
+ // Build name identifiers from extracted entities
+ Map<Entity.EntityType, NameIdentifier> nameIdentifierMap =
+ NameIdentifierUtil.buildNameIdentifierMap(entities);
+
+ // Extract full name and object type for metadata objects
+ Optional<String> fullName =
+ extractAnnotatedValue(parameters, args, AuthorizationFullName.class);
+ Optional<String> metadataObjectType =
+ extractAnnotatedValue(parameters, args, AuthorizationObjectType.class);
+
+ // Handle fullName and metadataObjectType if present
+ if (fullName.isPresent() && metadataObjectType.isPresent()) {
+ String metalake = entities.get(Entity.EntityType.METALAKE);
+ if (metalake != null) {
+ MetadataObject.Type type =
+
MetadataObject.Type.valueOf(metadataObjectType.get().toUpperCase(Locale.ROOT));
+ NameIdentifier nameIdentifier =
+ MetadataObjectUtil.toEntityIdent(metalake,
MetadataObjects.parse(fullName.get(), type));
+ nameIdentifierMap.putAll(
+ MetadataAuthzHelper.splitMetadataNames(
Review Comment:
It renamed to spilitNameIdentifier and move to NameIdentifierUtil.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
