Copilot commented on code in PR #9502:
URL: https://github.com/apache/gravitino/pull/9502#discussion_r2626832318
##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -849,7 +850,9 @@ private boolean containsUserCreatedSchemas(
}
private boolean includeManagedEntities(CatalogEntity catalogEntity) {
- return catalogEntity.getType().equals(FILESET);
+ return catalogEntity.getType().equals(FILESET)
+ || (catalogEntity.getType() == RELATIONAL
+ &&
"lakehouse-generic".equalsIgnoreCase(catalogEntity.getProvider()));
Review Comment:
Inconsistent comparison operators for catalog type. Line 853 uses
`.equals()` to compare with FILESET, while line 854 uses `==` to compare with
RELATIONAL. For consistency and best practices, both comparisons should use
`.equals()` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
