mchades commented on code in PR #9507:
URL: https://github.com/apache/gravitino/pull/9507#discussion_r2630858032
##########
api/src/main/java/org/apache/gravitino/credential/S3SecretKeyCredential.java:
##########
@@ -29,6 +29,10 @@ public class S3SecretKeyCredential implements Credential {
/** S3 secret key credential type. */
public static final String S3_SECRET_KEY_CREDENTIAL_TYPE = "s3-secret-key";
+ /** S3 scheme. */
+ public static final String S3_SCHEME = "s3";
+ /** S3A scheme (Hadoop S3A connector). */
+ public static final String S3A_SCHEME = "s3a";
Review Comment:
These variables are being redefined repeatedly. Could we move them to
`hadoop-common` or `catalog-common`?
##########
core/src/main/java/org/apache/gravitino/connector/credential/PathContext.java:
##########
@@ -31,16 +34,35 @@ public class PathContext {
private final String path;
private final String credentialType;
+ private final String scheme;
/**
* Constructs a new {@code PathContext} instance with the given path and
credential type.
*
* @param path The path string.
* @param credentialType The type of the credential.
*/
+ @Deprecated
+ @InlineMe(replacement = "this(path, credentialType, null)")
Review Comment:
why need this annotation?
##########
core/src/main/java/org/apache/gravitino/connector/credential/PathContext.java:
##########
@@ -31,16 +34,35 @@ public class PathContext {
private final String path;
private final String credentialType;
+ private final String scheme;
/**
* Constructs a new {@code PathContext} instance with the given path and
credential type.
*
* @param path The path string.
* @param credentialType The type of the credential.
*/
+ @Deprecated
Review Comment:
This method is an internal method of the core module. Can we modify it
directly without this annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
