jerryshao commented on code in PR #9513:
URL: https://github.com/apache/gravitino/pull/9513#discussion_r2638547215
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/LanceExceptionMapper.java:
##########
@@ -42,6 +42,8 @@ public static Response toRESTResponse(String instance,
Exception ex) {
? (LanceNamespaceException) ex
: toLanceNamespaceException(instance, ex);
+ LOG.error("Handling Lance exception: {}", lanceException.getMessage());
Review Comment:
What's the meaning of "handling"? Did you handle anything? Should you
explain the details of "handling" in the log message for users to understand?
The log should show the status of the exception (the fact), should not show
something like doing something without a meaningful message, which is
meaningless and only for you to debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
