jerqi commented on code in PR #9507:
URL: https://github.com/apache/gravitino/pull/9507#discussion_r2638889225
##########
clients/filesystem-hadoop3/src/test/java/org/apache/gravitino/filesystem/hadoop/integration/test/GravitinoVirtualFileSystemS3CredentialIT.java:
##########
@@ -107,10 +107,9 @@ public void startUp() throws Exception {
conf.set("fs.gvfs.impl.disable.cache", "true");
conf.set("fs.gravitino.server.uri", serverUri);
conf.set("fs.gravitino.client.metalake", metalakeName);
+ conf.set("fs.gravitino.enableCredentialVending", "true");
// Pass this configuration to the real file system
- conf.set(S3Properties.GRAVITINO_S3_SECRET_ACCESS_KEY, S3_SECRET_KEY);
- conf.set(S3Properties.GRAVITINO_S3_ACCESS_KEY_ID, S3_ACCESS_KEY);
Review Comment:
Because client shouldn't set AK/SK, we should use crendial vending token
here.
But we use a S3 filesystem to verify the tests which needs the AK/SK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
