danhuawang commented on code in PR #9511: URL: https://github.com/apache/gravitino/pull/9511#discussion_r2639209059
########## dev/charts/gravitino-lance-rest-server/resources/gravitino-lance-rest-server.conf: ########## @@ -0,0 +1,50 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# THE CONFIGURATION FOR Lance REST SERVER +gravitino.lance-rest.shutdown.timeout = {{ .Values.lanceRest.shutdownTimeout | default 3000 }} + +# THE CONFIGURATION FOR Lance REST WEB SERVER +# The host name of the built-in web server +gravitino.lance-rest.host = {{ .Values.lanceRest.host | default "0.0.0.0" }} +gravitino.lance-rest.httpPort = {{ .Values.lanceRest.httpPort | default 9101 }} +gravitino.lance-rest.minThreads = {{ .Values.lanceRest.minThreads | default 24 }} +gravitino.lance-rest.maxThreads = {{ .Values.lanceRest.maxThreads | default 200 }} +gravitino.lance-rest.stopTimeout = {{ .Values.lanceRest.stopTimeout | default 30000 }} +gravitino.lance-rest.idleTimeout = {{ .Values.lanceRest.idleTimeout | default 30000 }} +gravitino.lance-rest.threadPoolWorkQueueSize = {{ .Values.lanceRest.threadPoolWorkQueueSize | default 100 }} +gravitino.lance-rest.requestHeaderSize = {{ .Values.lanceRest.requestHeaderSize | default 131072 }} +gravitino.lance-rest.responseHeaderSize = {{ .Values.lanceRest.responseHeaderSize | default 131072 }} + +# THE CONFIGURATION FOR Lance namespace backend +# The backend Lance namespace for Lance REST service, it's recommended to use Gravitino +gravitino.lance-rest.namespace-backend = {{ .Values.lanceRest.namespaceBackend | default "gravitino" }} +# The uri of the Lance REST service gravitino namespace backend +gravitino.lance-rest.gravitino-uri = {{ .Values.lanceRest.gravitinoUri | default "http://localhost:8090"; }} +# The metalake name used for Lance REST service gravitino namespace backend, please create the metalake before using it, and configure the metalake name here. +{{- if .Values.lanceRest.gravitinoMetalake }} +gravitino.lance-rest.gravitino-metalake = {{ .Values.lanceRest.gravitinoMetalake }} +{{- else }} +# gravitino.lance-rest.gravitino-metalake = metalake +{{- end }} Review Comment: Fixed as following ``` helm install lrs ./gravitino-lance-rest-server -n test2 Error: INSTALLATION FAILED: execution error at (gravitino-lance-rest-server/templates/deployment.yaml:36:28): lanceRest.gravitinoMetalake must be set when namespaceBackend is gravitino ``` ########## dev/charts/gravitino-lance-rest-server/Chart.yaml: ########## @@ -0,0 +1,47 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +apiVersion: v2 +name: gravitino-lance-rest-server +description: Apache Gravitino's Lance REST server provides high-performance columnar data management via RESTful APIs, supporting HDFS/S3/OSS/Azure/GCS storage backends, and Lance format compatibility for analytical workloads. + +home: https://gravitino.apache.org +icon: https://gravitino.apache.org/img/apache-gravitino.svg +keywords: + - gravitino + - lance + - metadata + - catalog Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
