jerryshao commented on code in PR #9563:
URL: https://github.com/apache/gravitino/pull/9563#discussion_r2647438662
##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -562,7 +560,7 @@ public void enableCatalog(NameIdentifier ident)
checkMetalake(metalakeIdent, store);
try {
- if (catalogInUse(store, ident)) {
+ if (getCatalogInUseValue(store, ident)) {
Review Comment:
My feeling of the current definition of `catalogInUse` and
`checkCatalogInUse` is not so accurate, it also includes the check of metalake,
we'd better improve the method name or split into to methods. Otherwise, it
will be misused by developers later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
