github-actions[bot] opened a new pull request, #9582:
URL: https://github.com/apache/gravitino/pull/9582
### What changes were proposed in this pull request?
This PR improves the drop behavior for lakehouse-generic catalogs to
properly handle managed entities (Lance tables).
**Changes:**
- Modified `CatalogManager.includeManagedEntities()` to include RELATIONAL
catalogs with provider 'lakehouse-generic'
- Added comprehensive integration test to verify drop behavior for both
managed and external tables
### Why are the changes needed?
Fix #9490
Currently, when dropping a lakehouse-generic catalog, only metadata is
deleted but the physical data (Lance tables managed by Gravitino) remains. This
PR ensures that:
- When dropping a managed catalog, both metadata and physical data are
properly cleaned up
- Managed tables' physical directories are deleted when catalog is dropped
- External tables' physical directories are preserved (not deleted)
### Does this PR introduce _any_ user-facing change?
Yes. After this change, dropping a lakehouse-generic catalog with
`force=true` will now also delete the physical data for managed Lance tables,
not just the metadata.
### How was this patch tested?
- Added integration test `testDropCatalogWithManagedAndExternalEntities()`
that verifies:
- Managed tables are properly deleted (both metadata and physical data)
- External tables' physical data is preserved
- Test passed successfully in multiple runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
