Copilot commented on code in PR #9430:
URL: https://github.com/apache/gravitino/pull/9430#discussion_r2659449392
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/SchemaMetaService.java:
##########
@@ -388,6 +372,98 @@ public int deleteSchemaMetasByLegacyTimeline(Long
legacyTimeline, int limit) {
});
}
+ private SchemaPO getSchemaPOByIdentifier(NameIdentifier identifier) {
+ NameIdentifierUtil.checkSchema(identifier);
+ return schemaPOFetcher().apply(identifier);
+ }
+
+ private SchemaPO getSchemaByFullQualifiedName(
+ String metalakeName, String catalogName, String schemaName) {
+ SchemaPO schemaPO =
+ SessionUtils.getWithoutCommit(
+ SchemaMetaMapper.class,
+ mapper ->
+ mapper.selectSchemaByFullQualifiedName(metalakeName,
catalogName, schemaName));
+ if (schemaPO == null) {
+ throw new NoSuchEntityException(
+ NoSuchEntityException.NO_SUCH_ENTITY_MESSAGE,
+ EntityType.CATALOG.name().toLowerCase(),
Review Comment:
The error message incorrectly refers to CATALOG when it should refer to
SCHEMA. When a schema is not found by its full qualified name, the exception
should indicate that the schema entity was not found, not the catalog.
```suggestion
EntityType.SCHEMA.name().toLowerCase(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
