tsungchih commented on code in PR #9483:
URL: https://github.com/apache/gravitino/pull/9483#discussion_r2672665508
##########
clients/client-python/gravitino/client/gravitino_metalake.py:
##########
@@ -293,7 +299,7 @@ def list_job_templates(self) -> List[JobTemplate]:
params = {"details": "true"}
url =
self.API_METALAKES_JOB_TEMPLATES_PATH.format(encode_string(self.name()))
response = self.rest_client.get(
- url, params=params, error_handler=JOB_ERROR_HANDLER
+ url, params=params, error_handler=ErrorHandlers.job_error_handler()
Review Comment:
Sorry for missing this thread and for my late reply. IMHO, I would vote to
keep it as-is rather than wrapping up error handlers into a utility class due
to simplicity and flatness provided that we got only these two options.
However, if there's a good justification showed it would be better to access
these error handlers via a utility class or other approaches, then just like
@jerryshao mentioned we should change them all thoroughly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
