FANNG1 commented on code in PR #9590:
URL: https://github.com/apache/gravitino/pull/9590#discussion_r2676234313
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/jdbc/postgresql/GravitinoPostgresJdbcCatalogFactory.java:
##########
@@ -31,7 +32,11 @@ public String gravitinoCatalogProvider() {
}
@Override
- public PropertiesConverter propertiesConverter() {
+ public CatalogPropertiesConverter catalogPropertiesConverter() {
+ return PostgresqlPropertiesConverter.INSTANCE;
+ }
+
Review Comment:
@OverRide is not used in gravitino
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/jdbc/mysql/GravitinoMysqlJdbcCatalogFactory.java:
##########
@@ -31,7 +32,11 @@ public String gravitinoCatalogProvider() {
}
@Override
- public PropertiesConverter propertiesConverter() {
+ public CatalogPropertiesConverter catalogPropertiesConverter() {
+ return MysqlPropertiesConverter.INSTANCE;
+ }
+
Review Comment:
@OverRide is not used in gravitino
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
