jerryshao commented on code in PR #9560:
URL: https://github.com/apache/gravitino/pull/9560#discussion_r2694270796
##########
api/src/main/java/org/apache/gravitino/function/FunctionCatalog.java:
##########
@@ -52,28 +51,17 @@ public interface FunctionCatalog {
/**
* Get a function by {@link NameIdentifier} from the catalog. The identifier
only contains the
* schema and function name. A function may include multiple definitions
(overloads) in the
- * result. This method returns the latest version of the function.
+ * result. This method returns the current version of the function.
*
- * @param ident A function identifier.
- * @return The latest version of the function with the given name.
- * @throws NoSuchFunctionException If the function does not exist.
- */
- Function getFunction(NameIdentifier ident) throws NoSuchFunctionException;
-
- /**
- * Get a function by {@link NameIdentifier} and version from the catalog.
The identifier only
- * contains the schema and function name. A function may include multiple
definitions (overloads)
- * in the result.
+ * <p>Note: Currently, the current version is always the latest version. In
the future, when
+ * rollback functionality is supported, the current version may differ from
the latest version.
Review Comment:
We don't have to emphasize the version thing here, since we don't actually
support any version-related operations. Can you update the javadoc here and the
function definition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
