diqiu50 commented on code in PR #9569:
URL: https://github.com/apache/gravitino/pull/9569#discussion_r2697572033


##########
docs/fileset-catalog-with-s3.md:
##########
@@ -28,14 +28,14 @@ Once the server is up and running, you can proceed to 
configure the Fileset cata
 
 In addition to the basic configurations mentioned in 
[Fileset-catalog-catalog-configuration](./fileset-catalog.md#catalog-properties),
 the following properties are necessary to configure a Fileset catalog with S3:
 
-| Configuration item             | Description                                 
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                   | Default value   | Required 
| Since version    |
-|--------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------|----------|------------------|
-| `filesystem-providers`         | The file system providers to add. Set it to 
`s3` if it's a S3 fileset, or a comma separated string that contains `s3` like 
`gs,s3` to support multiple kinds of fileset including `s3`.                    
                                                                                
                                                                                
                                                                                
                                                    | (none)          | Yes     
 | 0.7.0-incubating |
-| `default-filesystem-provider`  | The name default filesystem providers of 
this Fileset catalog if users do not specify the scheme in the URI. Default 
value is `builtin-local`, for S3, if we set this value, we can omit the prefix 
's3a://' in the location.                                                       
                                                                                
                                                                                
                                                           | `builtin-local` | 
No       | 0.7.0-incubating |
-| `s3-endpoint`                  | The endpoint of the AWS S3.                 
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                   | (none)          | Yes      
| 0.7.0-incubating |
-| `s3-access-key-id`             | The access key of the AWS S3.               
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                   | (none)          | Yes      
| 0.7.0-incubating |
-| `s3-secret-access-key`         | The secret key of the AWS S3.               
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                   | (none)          | Yes      
| 0.7.0-incubating |
-| `credential-providers`         | The credential provider types, separated by 
comma, possible value can be `s3-token`, `s3-secret-key`. As the default 
authentication type is using AKSK as the above, this configuration can enable 
credential vending provided by Gravitino server and client will no longer need 
to provide authentication information like AKSK to access S3 by GVFS. Once it's 
set, more configuration items are needed to make it works, please see 
[s3-credential-vending](security/credential-vending.md#s3-credentials) | (none) 
         | No       | 0.8.0-incubating |
+| Configuration item            | Description                                  
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                  | Default value   | Required 
| Since version    |
+|-------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------|----------|------------------|
+| `filesystem-providers`        | (deprected) The file system providers to 
add. Set it to `s3` if it's a S3 fileset, or a comma separated string that 
contains `s3` like `gs,s3` to support multiple kinds of fileset including `s3`. 
                                                                                
                                                                                
                                                                                
                                                           | (none)          | 
Yes      | 0.7.0-incubating |

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to