FANNG1 commented on PR #9588:
URL: https://github.com/apache/gravitino/pull/9588#issuecomment-3766205743
> > Seems missing the transform logic for special config values:
> >
> > * json str like `options` and `spark_conf`, user input is {"a":"b"}, but
argument requires `'{\"a\":\"b\"}' `
> > * string with black space and `"` like `where`, user input is `status =
"active''` but argument requires `'status = \''active\'' '`
> > * string with `'`, like `status = 'active'`, should we prohibit this
input format?
>
> Can you explain more? I'm not quite following your comment here.
Take `options` for example, the user will pass `options` as a config key
and a json str like {"target-file-size-bytes":"536870912"} as config value,
the job manager will use --options {"target-file-size-bytes":"536870912"} to
run the rewrite job, seems this is not expected, we should do some special
handling like using `'` to wrappe the option string , and add `/` before `"`,
please correct me if there are some misunderstanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
